Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: add pip dependencies #233

Merged
merged 5 commits into from
May 28, 2024
Merged

build: add pip dependencies #233

merged 5 commits into from
May 28, 2024

Conversation

casperdcl
Copy link
Member

@casperdcl casperdcl commented Apr 30, 2024 •
edited

@casperdcl casperdcl self-assigned this Apr 30, 2024
@casperdcl casperdcl added bug Something isn't working waiting for review labels Apr 30, 2024
paskino
paskino reviewed Apr 30, 2024
View reviewed changes
Copy link
Contributor

@paskino paskino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cilviewer is a dependency but it is not available in pypi and the build fails. How do we proceed?

@casperdcl casperdcl force-pushed the fix-pip branch 4 times, most recently from 422fc13 to e54c581 Compare May 1, 2024 12:24
@casperdcl
Copy link
Member Author

I added an ultra basic test (actually try to import something!) and was missing libgl-dev to import vtk.

ready to merge now :)

@casperdcl casperdcl requested a review from paskino May 1, 2024 12:35
@DanicaSTFC DanicaSTFC added this to the Version 24.0.0 milestone May 2, 2024
DanicaSTFC
DanicaSTFC requested changes May 21, 2024
View reviewed changes
src/idvc/__init__.py Show resolved Hide resolved
@DanicaSTFC
Change registration tab name (#241)
7926050 
- Edit registration-tab name from "Manual" to "Initial"
@DanicaSTFC DanicaSTFC merged commit 4fc64e6 into master May 28, 2024
3 checks passed
@DanicaSTFC DanicaSTFC deleted the fix-pip branch May 28, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paskino paskino paskino approved these changes

@DanicaSTFC DanicaSTFC DanicaSTFC approved these changes

Assignees

@casperdcl casperdcl

Labels
bug Something isn't working
Projects
iDVC Planning
Archived in project
Milestone
Version 24.0.0
Development

Successfully merging this pull request may close these issues.

fix pip install fix CI builds
3 participants
@casperdcl @paskino @DanicaSTFC