improvement: default disposeOld
of setContext
to true
#881
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: if the user doesn't want the old context to get disposed, he must explicitly pass
false
Depends on #880
Marked as WIP because
disposeOld
parameter tosetContext
#880, makingsetContext
not acceptAnyAudioContext
.Tone.js/Tone/core/context/Offline.ts
Line 58 in 599e61f
OfflineContext
be disposed?)