Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: default disposeOld of setContext to true #881

Closed

Conversation

WofWca
Copy link
Contributor

@WofWca WofWca commented Apr 21, 2021

BREAKING CHANGE: if the user doesn't want the old context to get disposed, he must explicitly pass false

Depends on #880

Marked as WIP because

@WofWca WofWca force-pushed the set-context-dispose-old-default-true branch from d4518b4 to b642d1c Compare April 21, 2021 04:22
This makes it harder to introduce a resource leak
BREAKING CHANGE: if the user doesn't want the old context to get disposed,
he must explicitly pass `false`
@WofWca WofWca force-pushed the set-context-dispose-old-default-true branch from b642d1c to 599e61f Compare April 21, 2021 06:27
@tambien
Copy link
Contributor

tambien commented Oct 13, 2021

Merging #880, but i think i won't merge this one for now. I think this feature would make more sense if it only disposed of any automatically created AudioContext, but i think in terms of the ownership of resources, it makes more sense for whoever created the AudioContext to dispose of that AudioContext instead of it being disposed of automatically.

@tambien tambien closed this Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants