Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graceful shutdown on stop() #628

Merged
merged 3 commits into from
Nov 30, 2017
Merged

Graceful shutdown on stop() #628

merged 3 commits into from
Nov 30, 2017

Conversation

marci4
Copy link
Collaborator

@marci4 marci4 commented Nov 30, 2017

Description

Added a graceful shutdown during stop()
This should make sure, that all remaining frames are send to the other endpoints

Related Issue

Fixes #620

Motivation and Context

Interrupting the selector thread is not the right way to cause the shutdown

How Has This Been Tested?

Tested with JUnit test Issue608

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@marci4 marci4 added this to the Release 1.3.7 milestone Nov 30, 2017
@marci4 marci4 added this to To do in Development via automation Nov 30, 2017
@marci4 marci4 merged commit dc2e828 into TooTallNate:master Nov 30, 2017
Development automation moved this from To do to Done Nov 30, 2017
@marci4 marci4 removed this from Done in Development Dec 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate cause for #580
1 participant