Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NPE on already bound port #662

Merged
merged 1 commit into from
Feb 5, 2018
Merged

NPE on already bound port #662

merged 1 commit into from
Feb 5, 2018

Conversation

marci4
Copy link
Collaborator

@marci4 marci4 commented Feb 5, 2018

Description

Check if selector is not null
Interrupt for selectorthread to avoid zombie threads

Related Issue

Fixes #661

Motivation and Context

Bug

How Has This Been Tested?

Added Issue661Test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@marci4
NPE on already bound port
51b63a2 
Fixes TooTallNate#661
Test for TooTallNate#661
Interrupt for selectorthread to avoid zombie threads
@marci4 marci4 added this to the Release 1.3.8 milestone Feb 5, 2018
@marci4 marci4 merged commit 105e2e0 into TooTallNate:master Feb 5, 2018
@marci4 marci4 mentioned this pull request Feb 5, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Server
Projects
None yet
Milestone
Release 1.3.8
Development

Successfully merging this pull request may close these issues.

NPE when address already in use
1 participant
@marci4