Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include reason for dc due to lost connection detection #671

Merged
merged 1 commit into from
Feb 27, 2018
Merged

Include reason for dc due to lost connection detection #671

merged 1 commit into from
Feb 27, 2018

Conversation

marci4
Copy link
Collaborator

@marci4 marci4 commented Feb 27, 2018

Description

Include reason for DC

Related Issue

Fixes #669

Motivation and Context

Documentation

How Has This Been Tested?

No tests needed.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@marci4 marci4 added this to the Release 1.3.8 milestone Feb 27, 2018
@marci4 marci4 added this to To do in Development via automation Feb 27, 2018
@marci4 marci4 merged commit 8a23263 into TooTallNate:master Feb 27, 2018
Development automation moved this from To do to Done Feb 27, 2018
@marci4 marci4 removed this from Done in Development Mar 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Documentation Refactor
Projects
None yet
Milestone
Release 1.3.8
Development

Successfully merging this pull request may close these issues.

Include information in the onClose call for the connection lost detection
1 participant
@marci4