Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable and Disable ping/pong #708

Merged
merged 1 commit into from
May 14, 2018
Merged

Enable and Disable ping/pong #708

merged 1 commit into from
May 14, 2018

Conversation

marci4
Copy link
Collaborator

@marci4 marci4 commented May 14, 2018

Description

Storing the state of the WebSocket and if setConnectionLostTimeout is used, the timer will be updated

Related Issue

#699

Motivation and Context

This allows the restart of the detection.

How Has This Been Tested?

No tests currently needed

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@marci4 marci4 merged commit 7f31927 into TooTallNate:master May 14, 2018
@marci4 marci4 mentioned this pull request May 14, 2018
Closed
@marci4 marci4 self-assigned this May 14, 2018
@marci4 marci4 added the Bug label May 14, 2018
@marci4 marci4 mentioned this pull request Jun 6, 2018
Closed
@marci4 marci4 added this to the Release 1.3.9 milestone Jul 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@marci4 marci4

Labels
Bug New Feature
Projects
None yet
Milestone
Release 1.3.9
Development

Successfully merging this pull request may close these issues.
1 participant
@marci4