Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove static from synchronize object #733

Merged
merged 1 commit into from
Jul 5, 2018
Merged

Remove static from synchronize object #733

merged 1 commit into from
Jul 5, 2018

Conversation

marci4
Copy link
Collaborator

@marci4 marci4 commented Jul 4, 2018

Description

Removes static for the synchronize object

Related Issue

Fixes #726

How Has This Been Tested?

Source review

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@marci4 marci4 requested a review from PhilipRoman July 4, 2018 16:07
@marci4 marci4 added the Refactor label Jul 4, 2018
@marci4 marci4 added this to the Release 1.3.9 milestone Jul 4, 2018
PhilipRoman
PhilipRoman approved these changes Jul 5, 2018
View reviewed changes
Copy link
Collaborator

@PhilipRoman PhilipRoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@marci4 marci4 merged commit dd831ce into TooTallNate:master Jul 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilipRoman PhilipRoman PhilipRoman approved these changes

Assignees
No one assigned
Labels
Refactor
Projects
None yet
Milestone
Release 1.3.9
Development

Successfully merging this pull request may close these issues.

Can we remove synchronized appending to queue, this will make code run multithreaded
2 participants
@marci4 @PhilipRoman