Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More improvement #805

Merged
merged 3 commits into from
Nov 11, 2018
Merged

More improvement #805

merged 3 commits into from
Nov 11, 2018

Conversation

marci4
Copy link
Collaborator

@marci4 marci4 commented Nov 6, 2018

Description

Reduced complexity
Removed found issues
Fixed wrong checks in tests

Related Issue

#749

Motivation and Context

Code quality

How Has This Been Tested?

automatic tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@marci4
More improvement
dbb9f73 
Reduced complexity
Removed found issues
Fixed wrong checks in tests
@marci4 marci4 added the Refactor label Nov 6, 2018
@marci4 marci4 added this to the Release 1.4.0 milestone Nov 6, 2018
@marci4 marci4 merged commit 033a1bb into TooTallNate:master Nov 11, 2018
This was referenced Jan 28, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilipRoman PhilipRoman PhilipRoman approved these changes

Assignees
No one assigned
Labels
Refactor
Projects
None yet
Milestone
Release 1.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@marci4 @PhilipRoman