Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Synchronize AbstractWebSocket #824

Merged
merged 2 commits into from
Dec 9, 2018
Merged

Synchronize AbstractWebSocket #824

merged 2 commits into from
Dec 9, 2018

Conversation

marci4
Copy link
Collaborator

@marci4 marci4 commented Dec 6, 2018 •
edited by PhilipRoman

Description

Synchronize around the public api related to the lost connection

Related Issue

#811

Motivation and Context

Improve thread safety

How Has This Been Tested?

Added additional unit test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@marci4 marci4 added this to the Release 1.4.0 milestone Dec 6, 2018
@marci4
Copy link
Collaborator Author

marci4 commented Dec 9, 2018

Thanks for your review!

@marci4 marci4 merged commit 5c15fb7 into TooTallNate:master Dec 9, 2018
@marci4 marci4 deleted the AbstractWebSocket branch December 9, 2018 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilipRoman PhilipRoman PhilipRoman approved these changes

Assignees
No one assigned
Labels
Bug Client Refactor Server
Projects
None yet
Milestone
Release 1.4.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marci4 @PhilipRoman