Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Numbers generate key objects #11

Closed
wants to merge 1 commit into from
Closed

Numbers generate key objects #11

wants to merge 1 commit into from

Conversation

iamphill
Copy link

Fixes #5

@dasilvacontin
Copy link

👍

1 similar comment
@peteruithoven
Copy link

👍

@brycebaril
Copy link

This PR doesn't fix all of the issues mentioned in #5 -- punctuation still does not produce a key object:

0 '3' { name: '3',
  ctrl: false,
  meta: false,
  shift: false,
  sequence: '3' }
0 '$' undefined
0 '.' undefined
0 ';' undefined

@stewart stewart mentioned this pull request Mar 24, 2015
Closed
jonschlinkert added a commit to jonschlinkert/keypress that referenced this pull request Aug 30, 2016
@jonschlinkert
Sorry for the noise, there are three other PRs for number keys, but t…
9694ef9 
…his adds support for both number keys and shift+number keys.

- resolves TooTallNate#11
- resolves TooTallNate#14
- resolves TooTallNate#16
@jonschlinkert jonschlinkert mentioned this pull request Aug 30, 2016
Open
@iamphill iamphill closed this Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Number key presses don't generate key objects.
4 participants
@iamphill @dasilvacontin @peteruithoven @brycebaril