Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support to the new mesh format of atoms 3 #9

Merged
merged 5 commits into from
Apr 5, 2019
Merged

Added support to the new mesh format of atoms 3 #9

merged 5 commits into from
Apr 5, 2019

Conversation

iaiotom
Copy link
Collaborator

@iaiotom iaiotom commented Mar 15, 2019

This will handle the new mesh format and also the old one at the same time. The old mesh are converted to the new format at loading time.

Copy link
Collaborator

@andrewkaufman andrewkaufman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @iaiotom. I only left a couple notes here. I'm sure you know more than I do regarding all the Atoms API changes. One thing I'd like though is more thorough testing, since we're not too familiar with the changes on your side, it'd be great to have higher confidence that these changes are going to (a) keep our existing shots rendering the same and (b) improve the experience with the newly cached data. In particular I'd like to see some testes verifying that the Sets are coming through now, and that the transform matrices, bounds, and mesh positions are all in the expected spaces.

src/AtomsGaffer/AtomsVariationReader.cpp Outdated Show resolved Hide resolved
src/AtomsGaffer/AtomsCrowdGenerator.cpp Outdated Show resolved Hide resolved
src/AtomsGaffer/AtomsCrowdGenerator.cpp Show resolved Hide resolved
…t issue-23, updated assets for new mesh format, updated tests for new assets, added uv indices issue-27
@iaiotom
Copy link
Collaborator Author

iaiotom commented Apr 1, 2019

I've added the tests for the last features I've added

@iaiotom
Copy link
Collaborator Author

iaiotom commented Apr 2, 2019

ACS-111 fix

@andrewkaufman
Copy link
Collaborator

Thanks @iaiotom ! Confirmed this fixes several issues on our end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants