Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and improve docker build action #151

Merged
merged 9 commits into from
Mar 3, 2023

Conversation

cmdoret
Copy link
Contributor

@cmdoret cmdoret commented Mar 3, 2023

Dear Holger,

Our previous PR (#149) had an issue with the GitHub action publishing docker images. We were fetching the binaries from maven at build time and mishandled version names. This PR fixes this and improves the action in the following ways:

  • Builds the package directly from Github source into the image using mvn.
  • Proper versioning:
    • On new GitHub releases, an image named e.g. ghcr.io/topquadrant/shacl:1.4.3 will be created.
    • On commits, an image named e.g. ghcr.io/topquadrant/shacl:1.4.3_b8f215a will be created. (where b8f215a is the commit sha)

I apologize for the additional PR, it should work as expected now (the first action will be triggered by the merge commit).

Have an excellent week-end!

@HolgerKnublauch HolgerKnublauch merged commit d7212a5 into TopQuadrant:master Mar 3, 2023
@HolgerKnublauch
Copy link
Collaborator

NP, these things are hard to try out without repo access...

@cmdoret
Copy link
Contributor Author

cmdoret commented Mar 3, 2023

Thanks @HolgerKnublauch it's working properly now! 🥳 but the "package" (docker image) is private which means only TopQuadrant members can download it. If this is OK for your organization, someone may fix it by changing the organization setting for package visibility (see screenshot below, Public should be ticked).

image

@cmdoret
Copy link
Contributor Author

cmdoret commented Mar 3, 2023

Update: Apparently this can also be done at the repository level:

Screencast.from.03-03-2023.12_27_28.PM.webm

@HolgerKnublauch
Copy link
Collaborator

I am getting "Setting is disabled by organization administrators."

Almost all TopQuadrant projects are private and commercial source code, so you will understand that I cannot risk fiddling with the settings if this exposes us even to the slightest risk.

@cmdoret
Copy link
Contributor Author

cmdoret commented Mar 3, 2023

No worries I understand, thanks a lot anyway!
Having the Dockerfile is already great (users can build the image themselves).
I think I will setup a GitHub action on our fork to keep it in sync and distribute images under our namespace then if that's OK (ghcr.io/sdsc-ord/shacl)

@HolgerKnublauch
Copy link
Collaborator

Sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants