Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept Inflector ^2.0 as well as ^1.4 #48

Merged
merged 1 commit into from
Jan 27, 2022
Merged

Accept Inflector ^2.0 as well as ^1.4 #48

merged 1 commit into from
Jan 27, 2022

Conversation

tremby
Copy link
Contributor

@tremby tremby commented Jan 25, 2022

This fixes (at least) the pluralize method to support PHP 7.4, which dropped support for the old syntax version 1.x of Inflector was using.

Closes #34

This fixes (at least) the `pluralize` method to support PHP 7.4, which
dropped support for the old syntax version 1.x of Inflector was using.

Closes #34
@michaelrog
Copy link
Member

Thanks! I think this should be fine. Could you PR to 3.x.dev please?

@tremby tremby changed the base branch from master to 3.x.dev January 27, 2022 21:01
@tremby
Copy link
Contributor Author

tremby commented Jan 27, 2022

OK, changed the base.

@michaelrog michaelrog merged commit 90fc44c into TopShelfCraft:3.x.dev Jan 27, 2022
@tremby tremby deleted the accept-inflector-2 branch January 27, 2022 21:17
@tremby
Copy link
Contributor Author

tremby commented Jan 27, 2022

Can I expect a release in the near future or should I proceed with a workaround in place in the mean time? Thanks.

@michaelrog
Copy link
Member

This update is included in 3.3.1. ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update icanboogie/inflector to 2.0 for PHP 7.4 support
2 participants