Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TSDK-647 Load Wallet Tutorial & Transfer to another Wallet Tutorial #163

Merged
merged 11 commits into from
Dec 4, 2023
Merged

TSDK-647 Load Wallet Tutorial & Transfer to another Wallet Tutorial #163

merged 11 commits into from
Dec 4, 2023

Conversation

DiademShoukralla
Copy link
Collaborator

@DiademShoukralla DiademShoukralla commented Dec 1, 2023 •
edited
Loading

Purpose

To begin documenting tutorials

Approach

  • Displayed the "Tutorials" section on the portal
  • Added 2 tutorials: Load New Wallet with funds from Genesis, Transfer from one wallet to another
  • Minor code change to WalletStateResource. This is since, without this change, I was unable to re-run code examples multiple times on my machine (the driver appears to get de-registered) and I had to keep restarting my machine.

Testing

  • Ensured all existing unit tests pass
  • Ensured all added standalone examples (i.e., "Breakpoint Check" and "Putting it all together" sections) work locally
  • Ensured npm run build and npm run serve are succesul (i.e, no broken links)

Tickets

  • Closes TSDK-647

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 1, 2023 •
edited
Loading

Test Results

201 tests  ±0   201 ✔️ ±0   23s ⏱️ ±0s
  18 suites ±0       0 💤 ±0 
  18 files   ±0       0 ❌ ±0 

Results for commit ef0e024. ± Comparison against base commit 47893ff.

♻️ This comment has been updated with latest results.

@DiademShoukralla DiademShoukralla changed the title TSDK-647 Tutorials [WIP] TSDK-647 Load Wallet Tutorial & Transfer to another Wallet Tutorial Dec 1, 2023
@DiademShoukralla DiademShoukralla self-assigned this Dec 1, 2023
@DiademShoukralla DiademShoukralla marked this pull request as ready for review December 1, 2023 22:17
mundacho
mundacho approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@mundacho mundacho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice tutorials 👍

@DiademShoukralla DiademShoukralla merged commit dfc2a7e into main Dec 4, 2023
4 checks passed
@DiademShoukralla DiademShoukralla deleted the TSDK-647 branch December 4, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mundacho mundacho mundacho approved these changes

Assignees

@DiademShoukralla DiademShoukralla

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DiademShoukralla @mundacho