This repository has been archived by the owner on Jul 26, 2022. It is now read-only.
Fix possible decompression error in zstd::istreambuf #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's possible that the Zstd stream will not decompress any data but still asks for more. I observed this in one instance in which Zstd would return '1' as a hint for the size of the next chunk of input data, but when fed with a single byte would not decompress anything. The previous implementation would ignore this and pass the same pointer for all three arguments of setg(). This may cause a segmentation fault or various other problems down the road (depending on compiler and optimization level).
|
Here's some test data that will produce a segfault without this fix: https://www.dropbox.com/s/4lo1brqsiim60e1/testdata.zstd?dl=0. Now, zstd -d and this stream implementation will yield the same output. |
ebetica
approved these changes
May 22, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible that the Zstd stream will not decompress any data but still asks
for more. I observed this in one instance in which Zstd would return '1' as a
hint for the size of the next chunk of input data, but when fed with a single
byte would not decompress anything. The previous implementation would ignore
this and pass the same pointer for all three arguments of setg(). This may cause
a segmentation fault or various other problems down the road (depending on
compiler and optimization level).