Skip to content
This repository has been archived by the owner on Jul 26, 2022. It is now read-only.

(Binary Serialization Part 0) Updated to latest version of FlatBuffers. #226

Merged
merged 9 commits into from
Nov 21, 2017

Conversation

dgant
Copy link
Contributor

@dgant dgant commented Nov 17, 2017

#213

I'll be issuing a series of pull requests which cover the full transition to binary serialization.


Updating to FlatBuffers 1.7.1.

  • Updated relevant FlatBuffers headers (it requires two more)
  • Updated flatc invocation script to verify that we're using the correct version of FlatBuffers

@jgehring @ebetica @syhw

@@ -57,6 +57,20 @@ enum class Any : uint8_t {
MAX = Error
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the autogenerated code produced by flatc.

@@ -0,0 +1,227 @@
#ifndef FLATBUFFERS_BASE_H_
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the two new flatbuffers headers.

@@ -0,0 +1,220 @@
/*
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the other new flatbuffers header.

@dgant dgant changed the title Updated to latest version of FlatBuffers. (Binary Serialization Part 0) Updated to latest version of FlatBuffers. Nov 17, 2017
@jgehring
Copy link
Member

Great, thanks for splitting up the PR!

dgant and others added 5 commits November 17, 2017 14:33
…e-frame-string

(Binary Serialization Part 2) Removing frame_string
…d-idl

(Binary Serialization Part 1) Updated TorchCraft IDL to include types for frame serialization
@dgant dgant merged commit 3fa15a2 into develop Nov 21, 2017
@dgant dgant deleted the update-flatbuffers branch April 17, 2018 21:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants