New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Library: Sort by recently played #459
Comments
I may be able to take a stab at this. Could you give me some direction - for instance, which class does the library gets loaded and where are the sorting options that I need to change? My hunch would be the PlayListSortOrder within BookSortService class, is this correct and is that the only place that changes need to be made? |
Hi @iamLoi !, that would be great, since the Watch app was introduced (or maybe CarPlay 🤔 not sure right now), the But well, yes you're on the right track, within For localization, use the content of the |
Let me know if you got any other question 👍 |
Any commands or anything I need to run to get all the dependencies ready to build/run the project? This project uses Carthage so I ran |
I made another branch and pushed my changes. Please verify and let me know if there's anything missing, otherwise feel free to merge it. |
@iamLoi ❤ thanks for joining the effort. To allow us to merge or review your work, you need to create a fork and create a pull request. |
@iamLoi I'll leave my comments on the PR 👍 |
@GianniCarlo If is this still pending, can i take a stab at it ? |
sure!, there's a PR opened #460 but after some feedback about project building, there hasn't been any updates to it. So you're welcome to do it 👌 |
@GianniCarlo Thanks a lot. That PR was confusing for me and had many unwanted changes. I have implemented here in this PR |
@GianniCarlo can you close this issue ? The PR is merged |
wops I forgot 😅, closing it now 👍 |
@mmurali88 if you add |
Thanks @pichfl . Will do that going forward |
Extracted from #456 - #456 (comment)
The text was updated successfully, but these errors were encountered: