-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISSUE-459 : Adding Most recent sort method #475
ISSUE-459 : Adding Most recent sort method #475
Conversation
@@ -31,6 +40,7 @@ enum SortError: Error { | |||
public enum PlayListSortOrder: String { | |||
case metadataTitle = "title" | |||
case fileName = "originalFileName" | |||
case sortByMostRecent = "lastPlayDate" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's change sortByMostRecent
to just mostRecent
, so when calling the function sort(by:type:...
we can have consistency with the other cases in this enum
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated based on comments.
This works great 👌, Re translation, we do have an alternative 👀, we could use the already translated key I'm open to both options regarding the translations, so let me know 👍 |
1. Adding Most recent sort method (Localizable only on Base / English) 2. Fixed sort descriptor for Date / String values ISSUE-459 : Updating code based on review comments
I went with the 2nd option mainly because I couldn't test the carplay option. While we do the UI re-vamp I will make sure to update it . For now I have added the "sort_most_recent_button" item to all localization files for you to update later. |
👌👌👌 |
Proposed changes
Implement most recently played item sort method for both the library view and the playlist view.
Types of changes
Checklist
Note :