Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forecasting updates #197

Merged
merged 21 commits into from
Jan 24, 2023
Merged

Forecasting updates #197

merged 21 commits into from
Jan 24, 2023

Conversation

ahalev
Copy link
Collaborator

@ahalev ahalev commented Jan 20, 2023 •
edited by github-actions bot
Loading

  • Bug fixes with setting forecast_horizon and forecast: other attributes depend on these and need to be updated.
  • Correct clipping of forecasts to be within observation space.
  • Forecasting persistence between step and reset calls: calling module.state should return the same value unless step or reset are called.

📚 Documentation preview 📚: https://pymgrid--197.org.readthedocs.build/en/197/

@ahalev
add forecast setter and protect forecaster
71ef5e8
@ahalev
set state dict keys in separate method
bcd4c5c
@ahalev
update forecast only when reset or step is called
13fc6ed
@ahalev
update forecast horizon setter to also set forecast horizon-dependent…
26b3293 
… attributes
@ahalev
add forecast shaped space attr to forecasters
d2bc5bd
@ahalev
add forecast_shape arg to get_forecaster
57a2161
@ahalev
add observation space setter to set dependent attributes
3d18f3e
@ahalev
formatting
0e24d03
@ahalev
update get_forecaster calls for new signature
d31f5f3
@ahalev
correct clipping in forecasts (to obs space bounds)
d0fb1b8
@ahalev
update set_forecaster for new get_forecaster signature
8a62abd
@ahalev
add new set_forecaster function to microgrid
8fcb5ed
@ahalev
formatting
5d57f34
@ahalev
bug fix for NoForecaster
e9721d5
@ahalev
add check if requesting forecast that is too large
f3dbf36
@ahalev
another size check
d41b382
@ahalev
add _update_step method
865dabd
@ahalev
add shape check to forecaster init
8cee88c
@ahalev
update gaussiannoiseforecaster to use shape passed on init
0dc4752
@ahalev
fix clipping
429d667
@ahalev
update tests
6634004
@ahalev ahalev merged commit 33d66c5 into master Jan 24, 2023
@ahalev ahalev deleted the ahalev_forecasting branch January 24, 2023 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ahalev