Fix toolbar overlaying frames #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Fullscreen" frames like the world map when maximized don't set the frame strata to FULLSCREEN, which I guess is what used to happen pre-world map rework. Instead they just bump up their frame levels, which is why opening things like the talent panel will show it above the world map. The best fix for this is to set the strata of the toolbar down to MEDIUM, which will cause it to no longer overlay such panels. This also fixes the issue whereby we'd overlay our own TRP main window with the toolbar if maximized.
Ellypse
approved these changes
Jul 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #324.
"Fullscreen" frames like the world map when maximized don't set the frame strata to FULLSCREEN, which I guess is what used to happen pre-world map rework. Instead they just bump up their frame levels, which is why opening things like the talent panel will show it above the world map.
The best fix for this is to set the strata of the toolbar down to MEDIUM, which will cause it to no longer overlay such panels. This also fixes the issue whereby we'd overlay our own TRP main window with the toolbar if maximized.