Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classic support #336

Merged
merged 31 commits into from Aug 18, 2019

Conversation

@Solanya
Copy link
Collaborator

commented Aug 16, 2019

The big one. Icon library is missing but this should be a separate issue, even if it means a temporary new file.

This wasn't tested on a live environment and as such might have lingering bugs, but as far as I've been able to check :

  • All the missing icons have been replaced on the Classic version.
  • The scan button has been fixed (was sneaking under the map)
  • Support for the old way of playing musics (because Blizzard)
  • "Disable while in war mode" will disable while in PvP on Classic
  • Image list for Classic (and icon list, to be replaced)
  • TEMP icon has been replaced by the question mark on all versions, made sense to me but open to feedback on reverting it to be Classic-only.

Remaining issues for launch :

  • Icons in the credits are missing on Classic. Given that we are going for duplicate localisation, this will be fixed there.

Remaining issues after launch :

  • The mount/pet API calls have been disabled until we can make proper tests in-game.
  • The main tutorial button has been disabled until we can replace the missing template.
totalRP3/libs/libs.xml Show resolved Hide resolved
totalRP3/resources/imageList.lua Outdated Show resolved Hide resolved
totalRP3/totalRP3.lua Outdated Show resolved Hide resolved
Solanya added 2 commits Aug 18, 2019

@Solanya Solanya merged commit e8250bf into development Aug 18, 2019

1 check passed

continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.