Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Classic support #336

Merged
merged 31 commits into from Aug 18, 2019
Merged

Classic support #336

merged 31 commits into from Aug 18, 2019

Conversation

Solanya
Copy link
Member

@Solanya Solanya commented Aug 16, 2019

The big one. Icon library is missing but this should be a separate issue, even if it means a temporary new file.

This wasn't tested on a live environment and as such might have lingering bugs, but as far as I've been able to check :

  • All the missing icons have been replaced on the Classic version.
  • The scan button has been fixed (was sneaking under the map)
  • Support for the old way of playing musics (because Blizzard)
  • "Disable while in war mode" will disable while in PvP on Classic
  • Image list for Classic (and icon list, to be replaced)
  • TEMP icon has been replaced by the question mark on all versions, made sense to me but open to feedback on reverting it to be Classic-only.

Remaining issues for launch :

  • Icons in the credits are missing on Classic. Given that we are going for duplicate localisation, this will be fixed there.

Remaining issues after launch :

  • The mount/pet API calls have been disabled until we can make proper tests in-game.
  • The main tutorial button has been disabled until we can replace the missing template.

Solanya and others added 20 commits May 23, 2019 07:27
@Solanya
Basic support for loading on Classic
f76275d
@Solanya
Point to my copy of Ellyb until we figure things out
64969c5
@Solanya
Merge pull request #297 from Solanya/feature/classic_support
c89d2dc 
Classic support
@Solanya
Merge remote-tracking branch 'origin/development' into feature/classi…
188ed8c 
…c_support

# Conflicts:
#	.gitmodules
#	totalRP3/tools/Locale.lua
#	totalRP3/totalRP3.toc
#	totalRP3_Data/totalRP3_Data.toc
@Solanya
Replaced icons in characteristics and temp icon, image list + tempora…
afe61ee 
…ry icon list
@Solanya
Updated character icons
6515abf
@Solanya
Changed toolbar icons
1aa561e
@Solanya
Additional icon replacements
3404703
@Solanya
Changed target frame buttons
1c0d055
@Solanya
Changed color reset texture
37df638
@Solanya
Added music support for Classic
5e6e34d
@Solanya
Replaced map warmode disable with PvP status on Classic
127320e
@Solanya
Map scan button changes for Classic
0f9e69a
@Solanya
Didn't miss you Travis
1af57f3
@Solanya
Revert Ellyb change
681f467
@Solanya
wtf formatting
f918019
@Solanya
Disable main tutorial button on Classic
ede0655
@Solanya
Added client check + warning
9aac9a0
@Solanya
Packager-handled Interface version in TOC
f26014a
@Solanya
Removed reference to Ellypse's defunct Patreon
2da0453
Meorawr
Meorawr reviewed Aug 17, 2019
View reviewed changes
totalRP3/libs/libs.xml Show resolved Hide resolved
totalRP3/resources/imageList.lua Outdated Show resolved Hide resolved
totalRP3/totalRP3.lua Outdated Show resolved Hide resolved
@Solanya Solanya merged commit e8250bf into development Aug 18, 2019
@Meorawr Meorawr deleted the feature/classic_support branch September 24, 2019 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Meorawr Meorawr Meorawr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Solanya @Meorawr