TBC Packager Support #534
Merged
TBC Packager Support #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upstream packager has (ahead-of-time) adopted our Blizzard-facing proposal for multiple interface version support such that it now supports distinct TOC tags for each target client which will replace the existing "Interface" TOC tag automatically when packaged. In addition the "bc" game version has been added, so new workflow steps for packaging have been added there.
Also fleshed out the TOC with some eXtra optional things.
Solanya
approved these changes
May 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upstream packager has (ahead-of-time) adopted the proposal for multiple interface version support, such that it now supports distinct TOC tags for each target client which will replace the existing "Interface" TOC tag automatically when packaged.
In addition the "bc" game version has been added, so new workflow steps for packaging have been added there.
See: Stanzilla/WoWUIBugs#68 and BigWigsMods/packager@2963e10.
Note that the project IDs for this are temporary at the moment and default to the retail project; as we're likely heading for the three-client scenario we might need to reconsider the Classic project being separate on CF/WoWI anyway and merge that back in, and handle the localization differences ourselves (perhaps by just appending
_CLASSICto some of the keys).No work has also been done on changing or removing the existing
@retail@or@non-retail@substitutions as upstream work there is pending; we'll possibly be getting a set of@version-{retail,classic,bc}@substitutions for each client.