Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wake up Sol, new taintless just dropped #775

Merged
merged 1 commit into from May 28, 2023
Merged

Conversation

Meorawr
Copy link
Member

@Meorawr Meorawr commented May 28, 2023

No description provided.

@Meorawr Meorawr added this to the 2.5.3 milestone May 28, 2023
@Meorawr Meorawr requested a review from Solanya May 28, 2023 18:35
@Meorawr Meorawr self-assigned this May 28, 2023
Copy link
Member

@Solanya Solanya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

holy hell

@Solanya Solanya merged commit ce6a519 into main May 28, 2023
1 check passed
@Solanya Solanya deleted the chore/down-with-the-taintless branch May 28, 2023 18:39
Solanya added a commit that referenced this pull request Sep 5, 2023
commit bf16227
Author: Ghost <Bcaltons5@gmail.com>
Date:   Tue Sep 5 13:30:58 2023 -0500

    Remove aggressive recycling (#791)

commit c2bbc7f
Author: Ghost <Bcaltons5@gmail.com>
Date:   Tue Sep 5 13:30:43 2023 -0500

    Crop long guild names on nameplates (#795)

    * Crop long guild names

    * Strings

    * Crop original guild name too

commit e376131
Author: Solanya <17127080+Solanya@users.noreply.github.com>
Date:   Sat Jul 22 16:08:16 2023 +0200

    Regroup TRP3_MainFrame OnLoad scripts (#789)

    * Regroup OnLoad scripts

    * I have special frames

commit b646cc1
Author: Solanya <solanya@totalrp3.info>
Date:   Sat Jul 22 02:55:48 2023 +0200

    Adjustments for icon browser performance

commit 648185e
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Tue Jul 11 21:44:27 2023 +0200

    Import CurseForge Localization (#786)

    Co-authored-by: GitHub <noreply@github.com>

commit c4110b2
Author: Solanya <solanya@totalrp3.info>
Date:   Tue Jul 11 21:42:02 2023 +0200

    Changelog

commit fa5280e
Author: Solanya <solanya@totalrp3.info>
Date:   Tue Jul 11 21:41:52 2023 +0200

    Version bump

commit 423d67c
Author: Solanya <solanya@totalrp3.info>
Date:   Tue Jul 11 21:41:42 2023 +0200

    Added 45 images to browser

commit 37812ec
Author: Daniel Yates <me@meorawr.io>
Date:   Tue Jul 11 19:05:47 2023 +0100

    Remove unused code from earlier WIP (#787)

commit f295caf
Author: Daniel Yates <me@meorawr.io>
Date:   Tue Jul 11 18:59:57 2023 +0100

    Make window buttons look prettier in Retail (#782)

    * Make window buttons look prettier in Retail

    This updates the maximize, minimize, and resize buttons on the main
    frame to use newer art assets in retail clients. The button positioning
    has been slightly altered to no longer bleed outside the frame.

    On classic clients the old assets are used, as the newer art doesn't
    exist there.

    For the resize button this doesn't update the styling of
    the TRP3_ResizeButton template itself. The new templates use a different
    frame size and I didn't want to spend any time going through and
    correcting every single usage of the resize button template.

    * Mirror disabled texture for resize

    * Remove resize init from art template

    The art template should just be for art; it shouldn't implicitly
    initialize resizing.

    * Use single extensible template for styled buttons

    Rather than creating one art template per button type (and one
    mixin each for client overrides) a new "styled button" template
    has been added that will configure regions of a button according to
    a named visual style like "CloseButton".

    * Load StyledButton.xml a bit earlier

    * Use new styles for all Close/Resize buttons

    There's other buttons in the UI that haven't been touched still for
    stuff like module options and profile actions; these might get improved
    in a bit or may not.

    * Update remaining buttons

    This largely impacts the "action" buttons that used the minimize
    assets elsewhere, like in the register list.

commit 778d2f0
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Wed Jul 5 22:26:14 2023 +0200

    Import CurseForge Localization (#783)

    Co-authored-by: GitHub <noreply@github.com>

commit ebf2c08
Author: Daniel Yates <me@meorawr.io>
Date:   Fri Jun 23 19:15:29 2023 +0100

    Fix erroneous comparisons (#781)

    Negation operators have a higher priority than relational ones; the
    expression (not x == y) ends up getting interpreted as ((not x) == y)
    rather than the intended (not (x == y)).

    This is now detected by luacheck which rightly gets angry about us
    doing this.

commit dd18482
Author: Daniel Yates <me@meorawr.io>
Date:   Fri Jun 23 19:15:22 2023 +0100

    Fix potential SetText error (#780)

commit 8bfb9b5
Author: Solanya <solanya@totalrp3.info>
Date:   Tue Jun 20 21:07:41 2023 +0200

    Toc + Version bump + Changelog

commit d41c618
Author: Daniel Yates <me@meorawr.io>
Date:   Tue Jun 20 19:54:13 2023 +0100

    Add option to hide minimize/maximize button (#776)

    Fixes #689. Realistically there's a lot of UI work that we're not going
    to get around to any time soon. As most of the UI behaves terribly
    while maximized, we may as well give people an option to avoid having
    to suffer if they accidentally click the accursed buttons.

commit de88d38
Author: Ghost <Bcaltons5@gmail.com>
Date:   Tue Jun 20 13:53:44 2023 -0500

    Banish malicious dice objects (#774)

    * Validate the structure of dice rolls

    Strictly checks if a dice object is valid before displaying a message to the user.

    * Validate structure fields

    * Some fields are optional

    ---------

    Co-authored-by: Daniel Yates <me@meorawr.io>

commit ce6a519
Author: Daniel Yates <me@meorawr.io>
Date:   Sun May 28 19:39:52 2023 +0100

    Wake up Sol, new taintless just dropped (#775)

commit c11127a
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Tue May 23 18:54:33 2023 +0200

    Bump requests from 2.28.1 to 2.31.0 (#773)

    Bumps [requests](https://github.com/psf/requests) from 2.28.1 to 2.31.0.
    - [Release notes](https://github.com/psf/requests/releases)
    - [Changelog](https://github.com/psf/requests/blob/main/HISTORY.md)
    - [Commits](psf/requests@v2.28.1...v2.31.0)

    ---
    updated-dependencies:
    - dependency-name: requests
      dependency-type: direct:production
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 1821659
Author: Daniel Yates <me@meorawr.io>
Date:   Sun May 21 11:39:02 2023 +0100

    Better handling of guild names in nameplates (#771)

    * Better handling of guild names in nameplates

    * Remove hiding of text via space-only guild names

commit d9f5e08
Author: Daniel Yates <me@meorawr.io>
Date:   Sun May 21 11:38:05 2023 +0100

    Trigger guild fallback on empty custom names (#772)

commit 9e7f951
Author: Solanya <solanya@totalrp3.info>
Date:   Mon May 8 11:27:43 2023 +0200

    Version bump + Changelog

commit 59f9cc3
Author: Ghost <Bcaltons5@gmail.com>
Date:   Mon May 8 04:15:27 2023 -0500

    Plater mod bug fixes (#765)

    * Fix errors being thrown when TRP is disabled

    * Fix (?) nameplates not being removed properly

    * Real fix for nameplates getting stuck

    * Handle nil `displayInfo.color`

    * Check if the nameplate is still on screen

    * Cleanup

    * Check after delay if nameplate is still visible

    * Check for ghost colors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants