Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace AkkaHttpBackend with AsyncHttpClientFutureBackend #4514

Merged
merged 3 commits into from Jul 27, 2023

Conversation

gskrobisz
Copy link
Member

In 5205163 we added readTimeout to HttpFlinkClient.findJobsByName.
Akka does not support such setting and sttp uses idleTimeout as readTimeout, see sttp.client3.akkahttp.AkkaHttpBackend :

  private def connectionSettings(r: Request[_, _]): ConnectionPoolSettings = {
    //...
    connectionPoolSettingsWithProxy
    .withUpdatedConnectionSettings(_.withIdleTimeout(r.options.readTimeout))
  } 

And that idle/readTimeout means that after timeout connection is killed via RST (see also akka/akka-http#3346).
Therefore, to avoid broken sessions of findJobsByName, when HttpFlinkClient is created we should replace use AsyncHttpClientFutureBackend instead of AkkaHttpBackend.

@arkadius
Copy link
Member

Please remember to change scenarioStateIdleTimeout parameter name and update docs related with this

@github-actions github-actions bot added the docs label Jul 26, 2023
@gskrobisz gskrobisz marked this pull request as ready for review July 26, 2023 12:27
@gskrobisz gskrobisz merged commit 2cac9fb into staging Jul 27, 2023
17 checks passed
@coutoPL coutoPL deleted the replace_http_backend branch August 16, 2023 13:14
@piotrp piotrp mentioned this pull request Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants