Fix resource close #4629
Merged
Fix resource close #4629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotrp
force-pushed
the
fix-resource-close
branch
from
5a37430
to
fa1bc09
Compare
coutoPL
reviewed
Aug 31, 2023
...ocessReports/src/main/scala/pl/touk/nussknacker/processCounts/influxdb/InfluxGenerator.scala
Show resolved
Hide resolved
It belongs to NussknackerApp
It's lifecycle extends beyond DeploymentManager
piotrp
force-pushed
the
fix-resource-close
branch
from
fa1bc09
to
1048688
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug introduced by #4514: reloading model using
/api/app/processingtype/reloadAPI causes application's sharedSttpBackendto close.Old backend implementation used
AkkaHttpBackend, which was created withterminateActorSystemOnClose = false, i.e. it did nothing whenclose()was called. Our new backend,AsyncHttpClientFutureBackend, defaults to closing all of its resources (closeClient = true).