New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ValidationExpressionParameterValidator #4887
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartektartanus
force-pushed
the
CustomSpelExpressionValidator
branch
3 times, most recently
from
October 18, 2023 08:28
10d31aa
to
81dcd0a
Compare
arkadius
reviewed
Oct 18, 2023
...onents-api/src/main/scala/pl/touk/nussknacker/engine/api/definition/ParameterValidator.scala
Outdated
Show resolved
Hide resolved
...onents-api/src/main/scala/pl/touk/nussknacker/engine/api/definition/ParameterValidator.scala
Outdated
Show resolved
Hide resolved
...onents-api/src/main/scala/pl/touk/nussknacker/engine/api/definition/ParameterValidator.scala
Outdated
Show resolved
Hide resolved
...onents-api/src/main/scala/pl/touk/nussknacker/engine/api/definition/ParameterValidator.scala
Outdated
Show resolved
Hide resolved
...onents-api/src/main/scala/pl/touk/nussknacker/engine/api/definition/ParameterValidator.scala
Outdated
Show resolved
Hide resolved
.../pl/touk/nussknacker/engine/lite/components/LiteKafkaUniversalAvroSchemaFunctionalTest.scala
Outdated
Show resolved
Hide resolved
...ssknacker/engine/lite/components/requestresponse/RequestResponseTestWithParametersTest.scala
Outdated
Show resolved
Hide resolved
scenario-api/src/main/scala/pl/touk/nussknacker/engine/graph/node.scala
Outdated
Show resolved
Hide resolved
.../pl/touk/nussknacker/engine/compile/nodecompilation/GenericNodeTransformationValidator.scala
Outdated
Show resolved
Hide resolved
...onents-api/src/main/scala/pl/touk/nussknacker/engine/api/definition/ParameterValidator.scala
Outdated
Show resolved
Hide resolved
bartektartanus
force-pushed
the
CustomSpelExpressionValidator
branch
from
October 18, 2023 09:25
81dcd0a
to
c1f9e79
Compare
arkadius
reviewed
Oct 18, 2023
.../main/scala/pl/touk/nussknacker/engine/definition/FragmentComponentDefinitionExtractor.scala
Outdated
Show resolved
Hide resolved
9 tasks
bartektartanus
force-pushed
the
CustomSpelExpressionValidator
branch
from
November 13, 2023 13:50
c1f9e79
to
2bb57b6
Compare
bartektartanus
force-pushed
the
CustomSpelExpressionValidator
branch
from
November 20, 2023 15:53
2bb57b6
to
bb487d7
Compare
bartektartanus
changed the title
SpelExpressionParameterValidator and ParameterValidator refactoring
ValidationExpressionParameterValidator
Nov 20, 2023
created: #5075 |
arkadius
reviewed
Nov 21, 2023
arkadius
reviewed
Nov 21, 2023
...onents-api/src/main/scala/pl/touk/nussknacker/engine/api/definition/ParameterValidator.scala
Outdated
Show resolved
Hide resolved
arkadius
reviewed
Nov 21, 2023
.../main/scala/pl/touk/nussknacker/engine/definition/FragmentComponentDefinitionExtractor.scala
Outdated
Show resolved
Hide resolved
bartektartanus
force-pushed
the
CustomSpelExpressionValidator
branch
8 times, most recently
from
November 27, 2023 11:28
4a77786
to
cb2e566
Compare
bartektartanus
force-pushed
the
CustomSpelExpressionValidator
branch
3 times, most recently
from
November 27, 2023 14:56
9171458
to
18c1664
Compare
arkadius
reviewed
Nov 27, 2023
.../main/scala/pl/touk/nussknacker/engine/definition/FragmentComponentDefinitionExtractor.scala
Outdated
Show resolved
Hide resolved
arkadius
reviewed
Nov 27, 2023
...onents-api/src/main/scala/pl/touk/nussknacker/engine/api/definition/ParameterValidator.scala
Outdated
Show resolved
Hide resolved
bartektartanus
force-pushed
the
CustomSpelExpressionValidator
branch
3 times, most recently
from
November 27, 2023 20:33
01da533
to
bc6b885
Compare
arkadius
approved these changes
Nov 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job
bartektartanus
force-pushed
the
CustomSpelExpressionValidator
branch
from
November 28, 2023 08:42
bc6b885
to
3d2635c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Checklist before merge