Bump Detekt version from 1.0.0-RC14 to 1.8.0 #218
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RC changelog (https://arturbosch.github.io/detekt/changelog-rc.html) includes the change from filters to includes/excludes in the rules. More details on this particular migration are here: https://arturbosch.github.io/detekt/howto-migratetestpattern.html Another RC change replaced warningThreshold and failThreshold with maxIssues, but Sputnik has its own scoring strategy. Since 1.0.0 (https://arturbosch.github.io/detekt/changelog.html) the changelog includes nice "notable changes" but no migration that would cause backward compatibility issue.
|
Marking as draft until I fix the build. |
|
Closing. I was way too naive with this, did not expect dependency conflicts with ktlint. |
|
Can you work on this further and resolve conflicts? |
|
I would love to, but I can't commit to being able to do so anytime soon. |
snooze92
changed the title
snooze92
changed the title
|
Expanded my scope to bumping all Kotlin-related dependencies: #225 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RC changelog (https://arturbosch.github.io/detekt/changelog-rc.html)
includes the change from filters to includes/excludes in the rules.
More details on this particular migration are here:
https://arturbosch.github.io/detekt/howto-migratetestpattern.html
Another RC change replaced warningThreshold and failThreshold with
maxIssues, but Sputnik has its own scoring strategy.
Since 1.0.0 (https://arturbosch.github.io/detekt/changelog.html) the
changelog includes nice "notable changes" but no migration that would
cause backward compatibility issue.