Bump Kotlin-related dependencies #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change, we bump all Kotlin-related dependencies to recent versions. This includes a Kotlin bump from 1.3 to 1.4, the migration from com.github.shyiko.ktlint to com.pinterest.ktlint and a significant upgrade of Detekt from 1.0.0-RC14 to 1.14.0. For running Detekt, a new tooling API was introduced. This means that the code that invoke Detekt can change not to use internal classes anymore. Calling a Kotlin DSL from Java looks a little verbose, but it still works nicely. For tests, the Detekt YAML file was reset from the latest default, then adapted slightly so the expected rules still get triggered. A few more minor changes were made to match expectations with the latest version. I also add a specific test for a new Detekt rule that has been added since the previous version we were using here... In terms of migration/changelong: - Changelog of Detekt RC versions: https://arturbosch.github.io/detekt/changelog-rc.html - Detekt include/exclude migration: https://arturbosch.github.io/detekt/howto-migratetestpattern.html - Release notes of Detekt, since: https://arturbosch.github.io/detekt/changelog.html - KtLint changelog: https://github.com/pinterest/ktlint/releases
Codecov Report
@@ Coverage Diff @@
## master #225 +/- ##
============================================
- Coverage 73.25% 72.38% -0.88%
+ Complexity 612 608 -4
============================================
Files 146 146
Lines 1963 1988 +25
Branches 128 131 +3
============================================
+ Hits 1438 1439 +1
- Misses 468 489 +21
- Partials 57 60 +3
Continue to review full report at Codecov.
|
|
Not sure how to improve coverage on |
|
Thank for your contribution! This is a great work! 👍 |
rufuslevi
pushed a commit
to rufuslevi/sputnik
that referenced
this pull request
Mar 12, 2024
With this change, we bump all Kotlin-related dependencies to recent versions. This includes a Kotlin bump from 1.3 to 1.4, the migration from com.github.shyiko.ktlint to com.pinterest.ktlint and a significant upgrade of Detekt from 1.0.0-RC14 to 1.14.0. For running Detekt, a new tooling API was introduced. This means that the code that invoke Detekt can change not to use internal classes anymore. Calling a Kotlin DSL from Java looks a little verbose, but it still works nicely. For tests, the Detekt YAML file was reset from the latest default, then adapted slightly so the expected rules still get triggered. A few more minor changes were made to match expectations with the latest version. I also add a specific test for a new Detekt rule that has been added since the previous version we were using here... In terms of migration/changelong: - Changelog of Detekt RC versions: https://arturbosch.github.io/detekt/changelog-rc.html - Detekt include/exclude migration: https://arturbosch.github.io/detekt/howto-migratetestpattern.html - Release notes of Detekt, since: https://arturbosch.github.io/detekt/changelog.html - KtLint changelog: https://github.com/pinterest/ktlint/releases Co-authored-by: Julien Lehuen <julien.lehuen@imc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, we bump all Kotlin-related dependencies to recent versions. This includes a Kotlin bump from 1.3 to 1.4, the migration from com.github.shyiko.ktlint to com.pinterest.ktlint and a significant upgrade of Detekt from 1.0.0-RC14 to 1.14.0.
For running Detekt, a new tooling API was introduced. This means that the code that invoke Detekt can change not to use internal classes anymore. Calling a Kotlin DSL from Java looks a little verbose, but it still works nicely.
For tests, the Detekt YAML file was reset from the latest default, then adapted slightly so the expected rules still get triggered. A few more minor changes were made to match expectations with the latest version. I also add a specific test for a new Detekt rule that has been added since the previous version we were using here...
In terms of migration/changelog: