Fix for duplicated comments #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| private Set<String> getSet() { | ||
| if (commentsCrcSet == null) { | ||
| commentsCrcSet = Sets.newHashSet(); |
There was a problem hiding this comment.
There is sequivalent com.google.common.collect metod. I'm afraid of jcommander.internal.Sets - it's internal and I don't know it.
|
Mayby you also could try making #13 with that change (changes in same code?) ?? We have way too much comments now and that would help us a lot.. |
- Shortened crc - Fixed NPE when no comments found
|
Just created you PR zygm0nt#1 |
- Now numbers < 0 should look way better - Uppercased all letters
- Will create test tumorrow
- Crc is not needed we are comparing whole line
- Repaired tests
Some fixes in multiple comments
|
@ingwarsw thanks, I've merged that. |
Conflicts: src/main/java/pl/touk/sputnik/connector/stash/StashFacade.java
|
Please review changes - would like to merge this. |
|
Good work! Now it needs refactoring 👍 |
rufuslevi
pushed a commit
to rufuslevi/sputnik
that referenced
this pull request
Mar 12, 2024
rufuslevi
pushed a commit
to rufuslevi/sputnik
that referenced
this pull request
Mar 12, 2024
Fix for duplicated comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.