Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter simple condition form :: Visual improvement #404

Merged
merged 3 commits into from
Jan 17, 2020
Merged

Filter simple condition form :: Visual improvement #404

merged 3 commits into from
Jan 17, 2020

Conversation

ToucanTokar
Copy link
Member

@ToucanTokar ToucanTokar commented Jan 17, 2020 •
edited
Loading

Multiselect dropdown enhancement to improve filter simple condition display.

Before the dropdown multiselect tag was pushing the content below :
image

Now it's positionned in absolute with a scrollbar and max-height :
image

It also contains other form improvement like better height size and change the old ugly arrow by a font awesome one :
image

@zegonz
Copy link
Contributor

zegonz commented Jan 17, 2020

ETQC j'ai un composant multiInputText dans le VQB mieux intégré

bloodstorms
bloodstorms approved these changes Jan 17, 2020
View reviewed changes
Copy link
Contributor

@bloodstorms bloodstorms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah 🔥
Bon c'est chaud de review du css à l'aveugle, je te fais confiance la dessus, en tout cas le rendu est top !!

@ToucanTokar ToucanTokar merged commit edf0bf9 into master Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bloodstorms bloodstorms bloodstorms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ToucanTokar @zegonz @bloodstorms