Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion: BattleSessionStartEvent & BattleSessionEndEvent #324

Closed
illumeleet opened this issue Jul 27, 2021 · 0 comments · Fixed by #385
Closed

Suggestion: BattleSessionStartEvent & BattleSessionEndEvent #324

illumeleet opened this issue Jul 27, 2021 · 0 comments · Fixed by #385
Assignees
@LlmDl
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
0.6.1

Comments

@illumeleet
Copy link
Contributor

Describe the solution you'd like
Implementation of these events would help plugin developers to hook into Battle Session without editing SiegeWar source code.
@illumeleet illumeleet added the enhancement New feature or request label Jul 27, 2021
@Goosius1 Goosius1 added the good first issue Good for newcomers label Jul 27, 2021
@LlmDl LlmDl added this to the 0.6.1 milestone Oct 9, 2021
LlmDl added a commit that referenced this issue Oct 9, 2021
@LlmDl
Add BattleSession events.
8a9d5b1 
BattleSessionStartedEvent
BattleSessionEndedEvent

Closes #324.
@LlmDl LlmDl mentioned this issue Oct 9, 2021
Merged
1 task
@LlmDl LlmDl self-assigned this Oct 9, 2021
LlmDl added a commit that referenced this issue Oct 9, 2021
@LlmDl
Add BattleSession events.
ed7c63c 
BattleSessionStartedEvent
BattleSessionEndedEvent

Closes #324.
@LlmDl LlmDl closed this as completed in #385 Oct 9, 2021
LlmDl added a commit that referenced this issue Oct 9, 2021
@LlmDl
Add BattleSession events. (#385)
de22cd2 
* Add BattleSession events.

BattleSessionStartedEvent
BattleSessionEndedEvent

Closes #324.

* Whitespace formatting.

* Add cancellable BattleSessionPreStartEvent.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LlmDl LlmDl

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
0.6.1
Development

Successfully merging a pull request may close this issue.

Add BattleSession events. TownyAdvanced/SiegeWar
3 participants
@LlmDl @Goosius1 @illumeleet