Fix banner not being placed inside of NationZones upon Siege start. #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upon Siege start.
Haxx0r-4559
approved these changes
Oct 29, 2021
LlmDl
changed the title
Warriorrrr
approved these changes
Oct 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When nationzones are enabled, sieges can be started but the banner used to start one is removed by Towny.
This PR changes the logic of the evaluatePlaceStandingBanner method, turning it into a boolean, which returns true when a banner is successfully placed to start a siege. All other scenarios either return false or end up throwing an exception which doesn't result in the TownyBuildEvent being un-cancelled.
New Nodes/Commands/ConfigOptions:
Relevant Issue ticket:
Closes #397
By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the SiegeWar License for perpetuity.