Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Peaceful town public spawns #833

Merged
merged 7 commits into from
May 18, 2023

Conversation

Goosius1
Copy link
Collaborator

@Goosius1 Goosius1 commented May 13, 2023

Description:

  • Since SW2.0.0, on servers with public /n spawns but not public /t spawns .... peaceful towns cannot maintain a stable public spawn, because the only one posssible is /n, and they cannot defend it.
  • This is a big problem for peaceful shopkeepers, who on those servers, often create "Shell Nations", using no other features except the nation spawn.
  • Ideally those shopkeepers could use the kind of transport system without any political baggage, such as public /t spawns or some sort of new road feature, however the first is not always possible and the second doesn't seem to be available at present.
  • This PR mitigates the issue by providing all Peaceful towns by default with a public spawn.
  • This PR also increases the default peacefulness-switch time from 5->7 days, to help ensure that towns which aren't really peaceful don't see this as a reason for switching back and forth between peaceful/non-peaceful.

New Nodes/Commands/ConfigOptions:

  # If this is true, peaceful towns have a public spawn.
  # 
  # TIP 1:
  # In Towny in 2023, many peaceful-builder players have a Critical Requirement to own public/effectively-public spawns, 
  # so that they can run-shops/demonstrate-builds.
  # In Servers configured for public /n spawns, but not public /t spawns, players often create 'Shell Nations', 
  # which they use just for the /n spawns.
  # SiegeWar cannot/will-not protect 'Shell Nations',
  # Thus, if your server is configured this way, set this value to 'true' to meet a critical requirement for peaceful-builder players.
  # 
  # TIP 2:
  # In Towny in 2023, the reason some servers disable public /t spawns, is to encourage 'infastructure' between towns.
  # While this is an interesting goal, it is is probably not as important as meeting the critical player requirement outlined above,
  # Thus although this feature could potentially interfere with infrastructure,
  # the problems it solves are probably more important than the problems it creates
  public_spawn_enabled: 'true'

Relevant Issue ticket:

Closes #831


  • I have tested this pull request for defects on a server.

By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the SiegeWar License for perpetuity.

@Goosius1 Goosius1 added the enhancement New feature or request label May 13, 2023
@Goosius1 Goosius1 added this to the 2.5.0 milestone May 13, 2023
@Goosius1 Goosius1 self-assigned this May 13, 2023
@Goosius1 Goosius1 requested a review from LlmDl May 13, 2023 15:31
Copy link
Member

@LlmDl LlmDl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One unneeded diff to clean up, otherwise good to go.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unneeded diff in this class.

@Goosius1 Goosius1 merged commit 3edfd99 into TownyAdvanced:master May 18, 2023
@Goosius1 Goosius1 deleted the peaceful_town_public_spawn branch May 18, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestion: Give peaceful towns a public spawn
2 participants