Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hard dependancy on TC #863

Merged
merged 3 commits into from
Jul 17, 2023

Conversation

Goosius1
Copy link
Collaborator

@Goosius1 Goosius1 commented Jul 16, 2023

Description:

  • Currently SW experiences errors if TC is not present
  • Fix it so that there's no errors even if TC is not present

New Nodes/Commands/ConfigOptions:

  • NA

Relevant Issue ticket:

Closes #861


  • I have tested this pull request for defects on a server.

By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the SiegeWar License for perpetuity.

@Goosius1 Goosius1 added the bug Something isn't working label Jul 16, 2023
@Goosius1 Goosius1 added this to the 2.6.2 milestone Jul 16, 2023
@Goosius1 Goosius1 requested a review from LlmDl July 16, 2023 20:53
@Goosius1 Goosius1 self-assigned this Jul 16, 2023
Copy link
Member

@LlmDl LlmDl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing the plugin.yml already has TownyChat in the softdepend and not the depends?

@Goosius1
Copy link
Collaborator Author

Yes, the plugin.yml has softdepend.

@Goosius1 Goosius1 merged commit 3f073c2 into TownyAdvanced:master Jul 17, 2023
@Goosius1 Goosius1 deleted the fix_tc_dependency branch July 17, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove hard dependancy on TownyChat
2 participants