Discord webhook #875
Merged
Discord webhook #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LlmDl
requested changes
Jul 20, 2023
src/main/java/com/gmail/goosius/siegewar/events/SiegeCampStartEvent.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gmail/goosius/siegewar/events/SiegeCampStartEvent.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gmail/goosius/siegewar/listeners/SiegeWarSelfListener.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gmail/goosius/siegewar/timeractions/AttackerTimedWin.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gmail/goosius/siegewar/timeractions/DefenderTimedWin.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gmail/goosius/siegewar/utils/SiegeWarBattleSessionUtil.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gmail/goosius/siegewar/utils/SiegeWarBattleSessionUtil.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gmail/goosius/siegewar/utils/SiegeWarBattleSessionUtil.java
Outdated
Show resolved
Hide resolved
|
also from what i was told in the discord this is the same webhook class that eventwar uses unless you've changed it since getting the class from peti way back when |
…. make the config notification toggles work. add siege remove notification
… ending it, add defending town name to remove notification, fix siege start notification check
|
all comments addressed, ready for re-review |
|
Hi @LlmDl I was talking to Ewof earlier, and he has addressed all the comments he is aware of. Pinging here to remind ourselves where we are at with this PR before we forget. |
LlmDl
requested changes
Jul 24, 2023
src/main/java/com/gmail/goosius/siegewar/events/SiegeCampStartEvent.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gmail/goosius/siegewar/listeners/SiegeWarSelfListener.java
Show resolved
Hide resolved
src/main/java/com/gmail/goosius/siegewar/utils/SiegeWarBattleSessionUtil.java
Outdated
Show resolved
Hide resolved
fix end notification not firing
1 task
LlmDl
requested changes
Jul 24, 2023
src/main/java/com/gmail/goosius/siegewar/settings/SiegeWarSettings.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gmail/goosius/siegewar/listeners/SiegeWarSelfListener.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gmail/goosius/siegewar/events/SiegeWarStartEvent.java
Outdated
Show resolved
Hide resolved
|
i pushed another commit called reviews idk y it doesn't show here on the pr but it's there |
|
I dont see the commit here. |
LlmDl
requested changes
Jul 24, 2023
src/main/java/com/gmail/goosius/siegewar/events/SiegeRemoveEvent.java
Outdated
Show resolved
Hide resolved
LlmDl
approved these changes
Jul 24, 2023
|
I will leave this to @Goosius1 to merge at his leisure. |
|
Great thanks Llama!. I'll now do a secondary review. |
Goosius1
reviewed
Jul 25, 2023
Goosius1
requested changes
Jul 25, 2023
Goosius1
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Users can now have siege war notifications in their discords
it uses the localization so works on all supported languages
New Nodes/Commands/ConfigOptions:
DISCORD_WEBHOOK (comment)
DISCORD_WEBHOOK_ENABLED (boolean)
DISCORD_WEBHOOK_URL (string)
DISCORD_WEBHOOK_NOTICIATION_SESSION_START (boolean)
DISCORD_WEBHOOK_NOTIFICATION_SESSION_END (boolean)
DISCORD_WEBHOOK_NOTIFICATION_SIEGECAMP_START (boolean)
DISCORD_WEBHOOK_NOTIFICATION_SIEGE_START (boolean)
DISCORD_WEBHOOK_NOTIFICATION_SIEGE_END (boolean)
DISCORD_WEBHOOK_NOTIFICATION_SIEGE_REMOVE (boolean)
Relevant Issue ticket:
By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the SiegeWar License for perpetuity.