Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Accuracy of Money Warnings #879

Merged

Conversation

Goosius1
Copy link
Collaborator

Description:

  • With current code, the money warnings can get skewed by towns/nations containing lots of money, either from admins testing or from Players cheating.
  • This PR helps to resolve those issues by:
    • Discounting NPC towns
    • Discounting towns with balances x3 or more times above the average

New Nodes/Commands/ConfigOptions:

NA


Relevant Issue ticket:

Closes #874


  • I have tested this pull request for defects on a server.

By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the SiegeWar License for perpetuity.

@Goosius1 Goosius1 added the enhancement New feature or request label Jul 23, 2023
@Goosius1 Goosius1 added this to the 2.8.0 milestone Jul 23, 2023
@Goosius1 Goosius1 requested a review from LlmDl July 23, 2023 11:47
@Goosius1 Goosius1 self-assigned this Jul 23, 2023
@Goosius1 Goosius1 merged commit 203aed1 into TownyAdvanced:master Jul 24, 2023
@Goosius1 Goosius1 deleted the money_warnings_discount_edge_cases branch July 24, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestion: Get money warnings to discount edge cases
2 participants