Fix messaging-related issues, webhooks, folia-related beacon exception, add BannerControlSessionEndedEvent #884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix besieged town name not getting sent to ingame translatable on siege remove fix session end webhook notification return from send notification if not active strip formatting from event messages properly
strip formatting for endMessage properly BannerControlSessionEndedEvent
Goosius1
reviewed
Jul 30, 2023
Goosius1
reviewed
Jul 30, 2023
src/main/java/com/gmail/goosius/siegewar/utils/DiscordWebhook.java
Outdated
Show resolved
Hide resolved
Goosius1
requested changes
Jul 30, 2023
|
Re-review complete. Just 1 comment |
LlmDl
changed the title
|
In the future this sort of PR should be broken up into groups:
This will make the final release page easier to digest as PR titles can be more descriptive. |
Goosius1
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
show help if args length is 0 (would throw exception before)
fix besieged town name not getting sent to ingame translatable on siege remove
fix session end webhook notification
before if a session ended and it had battles there'd be an exception and no webhook notification but now it works
return from send notification if not active
strip formatting from event messages properly
fix beacon exceptions on folia
add BannerControlSessionEndedEvent
Description:
New Nodes/Commands/ConfigOptions:
Relevant Issue ticket:
By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the SiegeWar License for perpetuity.