Configurable banner capture/control session radius #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Allows the operator of the server to configure the distance the banner can be captured at, following the same rules for the radius as before.
Does not change default behaviour, negative values will default to Town Block size and default is -1 - This does mean that it cannot be "disabled" - setting it to 0 is theoretically possible to capture (this can be tested by tp to banner location with .0 added to each coordinate) but likely impossible in reality. - This could easily be rectified by changing "0" to use Town Block Radius, and negative values to disabling it entirely (or simply returning that they are not in the zone as it would be impossible) - Felt this was not relevant, the intention is not to allow it to be disabled and this would realistically be a different configuration that fully disables the feature and checks.
Does not require changes to language files.
New Nodes/Commands/ConfigOptions:
New config option:
war.siege.distances.banner_control_session_radius_blocksdefaulting to-1Relevant Issue ticket:
N/A
Tested against Paper 1.20.4 and Towny 0.100.2.0, no faults when tested with default, negative, zero and positive values, behaviour is as expected.
Not tested against other versions, Spigot or other forks as the changes are minimal.
By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the SiegeWar License for perpetuity.