Add option to use world key instead of world name #7388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure what happened with the newlines, but I re-added them. |
Warriorrrr
requested changes
Apr 28, 2024
Towny/src/main/java/com/palmergames/bukkit/towny/TownyFormatter.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Warrior <50800980+Warriorrrr@users.noreply.github.com>
Extracts world slug to a method.
LlmDl
approved these changes
Apr 30, 2024
Warriorrrr
approved these changes
May 2, 2024
LlmDl
added a commit
that referenced
this pull request
May 6, 2024
with PR #7402. - Fix Towny not loading on older minecraft servers missing FileNameUtils modern methods, courtesy of Warrior with PR #7403. - Closes #7399. - Allow setting a default plot price of -1, courtesy of Warrior with PR #7313. - A town can now prevent their plots going up for sale by setting a plot price of -1, using /t set plotprice -1. - Closes #7295. - Add option to use world key instead of world name, courtesy of gecko10000 with PR #7388. (First-Time Contributor!) - New Config Option: plugin.interfacing.web_map.world_name_uses_world_key - Default: false - If enabled, the world name placeholder will be replaced with the world key instead of the Bukkit name. - This should be enabled if you use SquareMap. - Bump adventure platform bukkit to 4.3.3-SNAPSHOT, courtesy of Warrior with PR #7395. - Adds support for 1.20.5/6 in Towny. - API: add NATION_LIST_BY, TOWN_LIST_BY TownyCommandAddons. - Closes #7397.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This adds the option to use a world's key for the webmap link instead of the world name. For example, squaremap uses the world's namespaced key and doesn't integrate with Towny's approach to this.
New Nodes/Commands/ConfigOptions:
Relevant Towny Issue ticket:
N/A
By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the Towny License for perpetuity.