-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
memory_store_tests::ensure_full_copy_of_bytes_is_made_test regularly failing #352
Comments
I keep encountering this as well during CI testing. I raised the limit from 1.1 to 1.2 already, but asan causes so much increase in memory usage that we'd probably need something like 1.6-1.8 here. I'm torn whether that's the right approach though since it would reduce the usefulness of the test for non-asan runs. Wdyt about disabling it for the asan workflow entirely? Or we could try to make memory usage of turbo cache more predictable? Another interesting option that I believe @allada already played around with is to use a different allocator altogether which likely has a big influence on this test. There is a good chance that tcmalloc or mimalloc could give us lower memory usage and an overall performance improvement essentially for free. |
I'd personally prefer to just disable the test for all sanatizers. This test is a very specific regression test, so I think it's ok to disable it under certain scenarios. |
Gathers stats over memory usage rather than one sample. closes #352
Gathers stats over memory usage rather than one sample. closes #352
Gathers stats over memory usage rather than one sample. closes #352
During the ASAN build the test memory_store_tests::ensure_full_copy_of_bytes_is_made_test regularly fails.
The text was updated successfully, but these errors were encountered: