Move AWS terraform to it's own directory #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in prep to support GCP and Azure.
allada
commented
Nov 3, 2023
There was a problem hiding this comment.
Reviewable status: 0 of 23 files reviewed, all discussions resolved (waiting on @MarcusSorealheis)
|
I already did this in my PR which will be wrapped up soon. |
allada
commented
Nov 3, 2023
There was a problem hiding this comment.
Yeah, we both need this, to prevent us from stepping on each other, we do it in a separate PR, then we can land independent of each other.
Reviewable status: 0 of 23 files reviewed, all discussions resolved (waiting on @MarcusSorealheis)
MarcusSorealheis
approved these changes
Nov 3, 2023
allada
commented
Nov 3, 2023
There was a problem hiding this comment.
Reviewed 23 of 23 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @MarcusSorealheis)
blakehatch
pushed a commit
to blakehatch/nativelink
that referenced
this pull request
Nov 21, 2023
This is in prep to support GCP and Azure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in prep to support GCP and Azure.
This change is