-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move AWS terraform to it's own directory #376
Conversation
This is in prep to support GCP and Azure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 23 files reviewed, all discussions resolved (waiting on @MarcusSorealheis)
I already did this in my PR which will be wrapped up soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we both need this, to prevent us from stepping on each other, we do it in a separate PR, then we can land independent of each other.
Reviewable status: 0 of 23 files reviewed, all discussions resolved (waiting on @MarcusSorealheis)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's good. I'm going to need to change my PR a bit to work with this but it should be fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 23 of 23 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @MarcusSorealheis)
This is in prep to support GCP and Azure.
This is in prep to support GCP and Azure.
This change is