Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AWS deployment #423

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Fix AWS deployment #423

merged 1 commit into from
Nov 28, 2023

Conversation

mhz5
Copy link
Contributor

@mhz5 mhz5 commented Nov 28, 2023

Description

#376 changes the structure of the deployment-examples directory, breaking the sample AWS deployment.
This PR changes some paths to fix the deployment.

This is my first (potential) contribution to the project. I found you guys through the bazel documentation, and am just poking around. Hope I can be of some use!

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

This PR is untested.
Perhaps it would be useful for me to follow up with a separate PR that creates a CI step that confirms the AWS deployment works?
Then another step that points a build at the sample deployment?

Checklist

  • Updated documentation if needed
  • Tests added/amended
  • bazel test //... passes locally
  • PR is contained in a single commit, using git amend see some docs

This change is Reviewable

@mhz5 mhz5 marked this pull request as ready for review November 28, 2023 08:12
Copy link
Member

@allada allada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Thank you very much, we have been heads down trying to catch up on all the changes lately in prep for a release and hiring people. You are a saint! 😄

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @mhz5)

@allada allada merged commit 4cc53bc into TraceMachina:main Nov 28, 2023
1 check passed
@mhz5 mhz5 deleted the mz/fix-aws-deploy branch November 28, 2023 17:33
TripleKai pushed a commit to TripleKai/turbo-cache that referenced this pull request Nov 29, 2023
Co-Authored-By: Ubuntu <ubuntu@ip-172-31-24-6.us-east-2.compute.internal>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants