Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Bazel build for Windows #317

Merged
merged 1 commit into from
Oct 18, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
# limitations under the License.

# Use the earliest supported C++ version for protoc.
build --cxxopt=-std=c++14 --host_cxxopt=-std=c++14 --repo_env=BAZEL_CXXOPTS=-std=c++14
build --cxxopt=-std=c++14 --host_cxxopt=-std=c++14

build --test_output=errors

Expand Down Expand Up @@ -49,3 +49,8 @@ build:tsan --config=nightly -c dbg
build:tsan --@rules_rust//:extra_rustc_flags=-Zsanitizer=thread
build:tsan --cache_test_results=no
build:tsan --run_under=//tools:tsan.sh

# Configuration options for Windows builds.
startup:windows --windows_enable_symlinks
build:windows --cxxopt=/std:c++14 --host_cxxopt=/std:c++14
build:windows --enable_runfiles
19 changes: 17 additions & 2 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,23 @@ on:
branches: [ main ]

jobs:
windows-tests:
windows-bazel-tests:
# The type of runner that the job will run on.
runs-on: windows-latest
steps:
- uses: actions/checkout@v3.5.3
with:
fetch-depth: 0
- uses: bazelbuild/setup-bazelisk@v2
- name: Mount Bazel cache
uses: actions/cache@v3
with:
path: "C:/tmp"
key: bazel-windows
- name: Test Bazel build on Windows
run: bazel --output_user_root=C:/tmp test --config=windows ...
shell: bash
windows-cargo-tests:
# The type of runner that the job will run on.
runs-on: windows-latest
steps:
Expand All @@ -19,7 +35,6 @@ jobs:
run: cargo build --all
- name: Test on windows
run: cargo test --all

cargo-tests:
# The type of runner that the job will run on.
runs-on: ubuntu-22.04
Expand Down
82 changes: 78 additions & 4 deletions Cargo.Bazel.lock
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"checksum": "e20d695c1b6eb23441e6126581ec3f80e3dd5d45305e301b36bd685264228987",
"checksum": "2c3f1e765c34a9f17991d83113aef0f1ba948d0bffedde6568223a3053d148ef",
"crates": {
"addr2line 0.20.0": {
"name": "addr2line",
Expand Down Expand Up @@ -12740,6 +12740,34 @@
"compile_data_glob": [
"**"
],
"crate_features": {
"common": [
"consoleapi",
"errhandlingapi",
"fileapi",
"handleapi",
"knownfolders",
"minwinbase",
"minwindef",
"ntdef",
"objbase",
"processenv",
"processthreadsapi",
"profileapi",
"psapi",
"shlobj",
"std",
"sysinfoapi",
"timezoneapi",
"winbase",
"wincon",
"winerror",
"winnt",
"ws2ipdef",
"ws2tcpip"
],
"selects": {}
},
"deps": {
"common": [
{
Expand Down Expand Up @@ -12983,6 +13011,39 @@
"compile_data_glob": [
"**"
],
"crate_features": {
"common": [
"Win32",
"Win32_Foundation",
"Win32_Globalization",
"Win32_NetworkManagement",
"Win32_NetworkManagement_IpHelper",
"Win32_Networking",
"Win32_Networking_WinSock",
"Win32_Security",
"Win32_Security_Authentication",
"Win32_Security_Authentication_Identity",
"Win32_Security_Credentials",
"Win32_Security_Cryptography",
"Win32_Storage",
"Win32_Storage_FileSystem",
"Win32_System",
"Win32_System_Com",
"Win32_System_Console",
"Win32_System_Diagnostics",
"Win32_System_Diagnostics_Debug",
"Win32_System_IO",
"Win32_System_Memory",
"Win32_System_Pipes",
"Win32_System_SystemServices",
"Win32_System_Threading",
"Win32_System_WindowsProgramming",
"Win32_UI",
"Win32_UI_Shell",
"default"
],
"selects": {}
},
"deps": {
"common": [
{
Expand Down Expand Up @@ -13578,9 +13639,12 @@
"cfg(all(target_arch = \"x86_64\", target_env = \"gnu\", not(target_abi = \"llvm\"), not(windows_raw_dylib)))": [
"x86_64-unknown-linux-gnu"
],
"cfg(all(target_arch = \"x86_64\", target_env = \"msvc\", not(windows_raw_dylib)))": [],
"cfg(all(target_arch = \"x86_64\", target_env = \"msvc\", not(windows_raw_dylib)))": [
"x86_64-pc-windows-msvc"
],
"cfg(any(target_arch = \"aarch64\", target_arch = \"x86_64\", target_arch = \"x86\"))": [
"aarch64-unknown-linux-gnu",
"x86_64-pc-windows-msvc",
"x86_64-unknown-linux-gnu"
],
"cfg(any(target_os = \"linux\", target_os = \"android\", target_os = \"macos\", target_os = \"ios\"))": [
Expand All @@ -13600,12 +13664,14 @@
"aarch64-unknown-linux-gnu",
"arm-unknown-linux-gnueabi",
"armv7-unknown-linux-gnueabi",
"x86_64-pc-windows-msvc",
"x86_64-unknown-linux-gnu"
],
"cfg(not(any(target_arch = \"wasm32\", target_arch = \"wasm64\")))": [
"aarch64-unknown-linux-gnu",
"arm-unknown-linux-gnueabi",
"armv7-unknown-linux-gnueabi",
"x86_64-pc-windows-msvc",
"x86_64-unknown-linux-gnu"
],
"cfg(not(any(target_os = \"windows\", target_os = \"macos\", target_os = \"ios\")))": [
Expand All @@ -13624,6 +13690,7 @@
"aarch64-unknown-linux-gnu",
"arm-unknown-linux-gnueabi",
"armv7-unknown-linux-gnueabi",
"x86_64-pc-windows-msvc",
"x86_64-unknown-linux-gnu"
],
"cfg(not(windows))": [
Expand All @@ -13639,18 +13706,25 @@
"cfg(target_os = \"hermit\")": [],
"cfg(target_os = \"redox\")": [],
"cfg(target_os = \"wasi\")": [],
"cfg(target_os = \"windows\")": [],
"cfg(target_os = \"windows\")": [
"x86_64-pc-windows-msvc"
],
"cfg(tokio_taskdump)": [],
"cfg(unix)": [
"aarch64-unknown-linux-gnu",
"arm-unknown-linux-gnueabi",
"armv7-unknown-linux-gnueabi",
"x86_64-unknown-linux-gnu"
],
"cfg(windows)": [],
"cfg(windows)": [
"x86_64-pc-windows-msvc"
],
"i686-pc-windows-gnu": [],
"x86_64-pc-windows-gnu": [],
"x86_64-pc-windows-gnullvm": [],
"x86_64-pc-windows-msvc": [
"x86_64-pc-windows-msvc"
],
"x86_64-unknown-linux-gnu": [
"x86_64-unknown-linux-gnu"
]
Expand Down
12 changes: 10 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -74,11 +74,19 @@ Runtime dependencies:
* `libssl-dev` or `libssl1.0-dev` (depending on your distro & version)
#### Bazel building for deployment
```sh
bazel build //cas
# On Unix
bazel build cas

# On Windows
bazel build --config=windows cas
```
#### Bazel building for release
```sh
bazel build -c opt //cas
# On Unix
bazel build -c opt cas

# On Windows
bazel build --config=windows -c opt cas
```
> **Note**
> Failing to use the `-c opt` flag will result in a very slow binary (~10x slower).
Expand Down
1 change: 1 addition & 0 deletions WORKSPACE
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ crates_repository(
"arm-unknown-linux-gnueabi",
"armv7-unknown-linux-gnueabi",
"x86_64-unknown-linux-gnu",
"x86_64-pc-windows-msvc",
],
)

Expand Down
Loading