Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close on complete in GrpcScheduler #328

Merged

Conversation

chrisstaite-menlo
Copy link
Collaborator

@chrisstaite-menlo chrisstaite-menlo commented Oct 20, 2023

Description

The GrpcScheduler fails to close the downstream Receiver when the upstream one completes. This causes it to hang forever even though its completed.

Fixes #323

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Using a GrpcScheduler in front of a SimpleScheduler to a Reclient.

Checklist

  • Updated documentation if needed
  • Tests added/amended
  • bazel test //... passes locally
  • PR is contained in a single commit, using git amend see some docs

This change is Reviewable

The GrpcScheduler fails to close the downstream Receiver when the upstream one
completes.  This causes it to hang forever even though its completed.

Fixes TraceMachina#323
@chrisstaite-menlo
Copy link
Collaborator Author

Tests not available due to #154.

Copy link
Member

@allada allada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We really need some GRPC testing framework :-(

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @chrisstaite-menlo)

@chrisstaite-menlo chrisstaite-menlo merged commit 6c937da into TraceMachina:main Oct 22, 2023
13 checks passed
@chrisstaite-menlo chrisstaite-menlo deleted the close_grpc_scheduler branch October 30, 2023 10:28
blakehatch pushed a commit to blakehatch/nativelink that referenced this pull request Nov 14, 2023
The GrpcScheduler fails to close the downstream Receiver when the upstream one
completes.  This causes it to hang forever even though its completed.

Fixes TraceMachina#323
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GrpcScheduler not working for Reclient
2 participants