Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GrpcScheduler not working for Reclient #323

Closed
chrisstaite-menlo opened this issue Oct 19, 2023 · 1 comment · Fixed by #328
Closed

GrpcScheduler not working for Reclient #323

chrisstaite-menlo opened this issue Oct 19, 2023 · 1 comment · Fixed by #328

Comments

@chrisstaite-menlo
Copy link
Collaborator

Using the Reclient with the GrpcScheduler fails to function. It appears that it times out on executions despite them being reported as completed. This works fine with the SimpleScheduler which is odd to me...
@chrisstaite-menlo chrisstaite-menlo mentioned this issue Oct 19, 2023
Merged
5 tasks
@chrisstaite-menlo
Copy link
Collaborator Author

This happens because it fails to close the downstream ActionState Receiver when the upstream is closed.

chrisstaite-menlo added a commit to chrisstaite-menlo/turbo-cache that referenced this issue Oct 20, 2023
@chrisstaite-menlo
Close on complete in GrpcScheduler
f5943c3 
The GrpcScheduler fails to close the downstream Receiver when the upstream one
completes.  This causes it to hang forever even though its completed.

Fixes TraceMachina#323
@chrisstaite-menlo chrisstaite-menlo mentioned this issue Oct 20, 2023
Merged
5 tasks
chrisstaite-menlo added a commit to chrisstaite-menlo/turbo-cache that referenced this issue Oct 20, 2023
@chrisstaite-menlo
Close on complete in GrpcScheduler
d7f6ea3 
The GrpcScheduler fails to close the downstream Receiver when the upstream one
completes.  This causes it to hang forever even though its completed.

Fixes TraceMachina#323
chrisstaite-menlo added a commit that referenced this issue Oct 22, 2023
@chrisstaite-menlo
Close on complete in GrpcScheduler (#328)
6c937da 
The GrpcScheduler fails to close the downstream Receiver when the upstream one
completes.  This causes it to hang forever even though its completed.

Fixes #323
blakehatch pushed a commit to blakehatch/nativelink that referenced this issue Nov 14, 2023
@chrisstaite-menlo @blakehatch
Close on complete in GrpcScheduler (TraceMachina#328)
013d203 
The GrpcScheduler fails to close the downstream Receiver when the upstream one
completes.  This causes it to hang forever even though its completed.

Fixes TraceMachina#323
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Close on complete in GrpcScheduler chrisstaite-menlo/turbo-cache
1 participant
@chrisstaite-menlo