-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve config JSON readability and composability #889
base: main
Are you sure you want to change the base?
Conversation
0118d04
to
3f44a5a
Compare
I hope you to review this. @MarcusSorealheis , @allada , @aaronmondal , @adam-singer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Blizzard for returning to contribute. I personally do not think this PR is ready for review. Can you take a look at the output
Reviewable status: 0 of 1 LGTMs obtained, and pending CI: Bazel Dev / ubuntu-22.04, Remote / large-ubuntu-22.04, asan / ubuntu-22.04, docker-compose-compiles-nativelink (20.04), docker-compose-compiles-nativelink (22.04), macos-13, ubuntu-22.04, and 1 discussions need to be resolved
deployment-examples/docker-compose/scheduler.json
line 16 at r2 (raw file):
}, { "name": "GRPC_LOCAL_AC_STORE", "config": {
instead of config
, we should be using options
. The whole file is a config.
Well, @allada wanted that to be What would be the correct wording for that? |
27db3c6
to
3ae01f4
Compare
We now have "name" and "options" field for an individual store and scheduler JSON for setting its name and its configurations. And "stores" and "schedulers" field now accepts array instead of map.
3ae01f4
to
c4c75c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 LGTMs obtained, and pending CI: Analyze (javascript-typescript), Analyze (python), Bazel Dev / ubuntu-22.04, Cargo Dev / macos-13, Cargo Dev / ubuntu-22.04, Local / ubuntu-22.04, Publish image, Publish nativelink-worker-lre-cc, Remote / large-ubuntu-22.04, asan / ubuntu-22.04, docker-compose-compiles-nativelink (20.04), docker-compose-compiles-nativelink (22.04), integration-tests (20.04), integration-tests (22.04), macos-13, pre-commit-checks, ubuntu-20.04 / stable, ubuntu-22.04, ubuntu-22.04 / stable, vale, windows-2022 / stable, and 1 discussions need to be resolved
deployment-examples/docker-compose/scheduler.json
line 16 at r2 (raw file):
Previously, MarcusSorealheis (Marcus Eagan) wrote…
instead of
config
, we should be usingoptions
. The whole file is a config.
Done.
|
Description
Currently, I've improved the readability and composability of the JSON file by applying the changes mentioned in the issue.
We now have "name" and "config" field for an individual store and scheduler JSON for setting its name and its configurations.
And "stores" and "schedulers" field now accepts array instead of map.
Fixes #834
Type of change
not work as expected)
Checklist
bazel test //...
passes locallygit amend
see some docsThis change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)