Fix test suite instability #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wejendorp
force-pushed
the
test-fix
branch
3 times, most recently
from
07b8b68
to
f06f3ec
Compare
|
Omg I think I finally got it to be not flaky! |
Kian-Esmaeilpour
suggested changes
Sep 24, 2020
There was a problem hiding this comment.
Nice job! LGTM but there are couple of things,
First please also update the README file: https://github.com/Tradeshift/io/blame/master/README.md#L194
Second, this is a breaking change IMO and we should bump major version, based on my search with livegrep Chrome is the only place using it, and it would be, hopefully, an easy update 👍
IE fails w/ permissionError when trying to use a removed iframe as a key during cleanup. This causes the cleanup to fail. This commit introduces an appId to token map, that allows cleanup to happen regardless of window state. BREAKING CHANGE: hub.forgetApp API signature now requires appId as well as target window.
Kian-Esmaeilpour
approved these changes
Sep 25, 2020
|
🎉 This PR is included in version 4.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IE fails w/ permissionError when trying to use a removed iframe as a key
during cleanup. When cleanup fails, timeouts are not cleared, and the tests fail.
This commit introduces an appId to token map, that allows cleanup to
happen regardless of window state / cross origin issues.