Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this is a docker image, then it is safe to assume that most of the time it will be used in a container behind another nginx proxy.
Let's consider the scenario:
Let's now consider the access:
Assuming
pub
is a directory, nginx will try to add the slash at the end, and the following redirect will take place:(Please do try it)
Both the protocol (https -> http) and the port (443 -> 8080) change, leaving the site unaccessible. A solution would be to disable
port_in_redirect
in the nginx configuration. That change produces:(Please try it)
The site is now accessible, but there's an extra redirect because of the protocol change.
absolute_redirect
leaves both the protocol and the port behind so a single redirect takes place.Even though the
nginx.conf
file can be changed by just binding another file to it, I think it would be better if the default config took this into account.