Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIActivityViewController support for iOS6+ #44

Closed
wants to merge 2 commits into from

Conversation

rileytestut
Copy link

By setting the new boolean useActivityViewController to YES, SVWebViewController will now present a UIActivityViewController instead of a UIActionSheet. SVWebViewController also now has an applicationActivities property where the programmer can pass in an array of custom UIActivities to display alongside the included ones.

For this implementation, I have included git submodules TUSafariActivity and ARChromeActivity for SVWebViewControllerAvailableActionsOpenInSafari and SVWebViewControllerAvailableActionsOpenInChrome because UIActivityViewController does not come with these activities. However, this means any person who clones your repo has to now do the extra step of updating the modules, so if you were aiming to be the easiest WebViewController to add to a product you may want to remove references to these.

@samvermette
Copy link
Member

I really want this to work, but the 3rd party dependencies are indeed bothering. Will try to think of what's the best way to do this.

@rileytestut
Copy link
Author

It shouldn't be too hard to reimplement them yourself, or even I could do it and send another pull request. The problem is that all UIActivities require an icon, and I certainly don't have the necessary designer skills to create my own versions.

@samvermette
Copy link
Member

Well reinventing the wheel is a waste of time imo. I think using existing open-source activities is the way to go...

@samvermette
Copy link
Member

Just pushed this to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants